Skip to content

docs: add ADR for relay authentication - #739

Merged
nogringo merged 2 commits into
masterfrom
docs/adr-relay-auth
Sep 2, 2026
Merged

docs: add ADR for relay authentication#739
nogringo merged 2 commits into
masterfrom
docs/adr-relay-auth

Conversation

@nogringo

@nogringo nogringo commented Aug 24, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Documentation
    • Added a proposed architecture decision documenting relay authentication behavior.
    • Defined authentication modes for never authenticating, optionally authenticating, and requiring authentication.
    • Documented configurable asynchronous authentication handling, including refusal reasons and request details.
    • Added guidance for read and write authentication requests.

@nogringo
nogringo requested review from 1-leo and frnandu August 24, 2026 18:10
@nogringo nogringo self-assigned this Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 478ad6f4-23b1-436b-a7d1-3beb9f4b22e3

📥 Commits

Reviewing files that changed from the base of the PR and between 38e50aa and 71630d1.

📒 Files selected for processing (1)
  • doc/library-development/ADRs/relay-auth.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/adr-relay-auth

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.66%. Comparing base (5a8cf9c) to head (270cfdb).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
- Coverage   72.44%   71.66%   -0.78%     
==========================================
  Files         227      227              
  Lines       13338    13338              
==========================================
- Hits         9663     9559     -104     
- Misses       3675     3779     +104

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

frnandu
frnandu approved these changes Aug 27, 2026
View reviewed changes

@frnandu frnandu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sound good!

1-leo
1-leo approved these changes Sep 1, 2026
View reviewed changes

@1-leo 1-leo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there alternatives of this?
otherwise good with me

@nogringo
nogringo merged commit d08785b into master Sep 2, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frnandu frnandu frnandu approved these changes
@1-leo 1-leo 1-leo approved these changes

Assignees

@nogringo nogringo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nogringo @frnandu @1-leo